Skip to content

fix: add hover style to tab within group (#716)#751

Merged
wewoor merged 1 commit into
DTStack:mainfrom
Zaoei:fix/tabsHoverBackground
May 25, 2022
Merged

fix: add hover style to tab within group (#716)#751
wewoor merged 1 commit into
DTStack:mainfrom
Zaoei:fix/tabsHoverBackground

Conversation

@Zaoei

@Zaoei Zaoei commented May 25, 2022

Copy link
Copy Markdown
Collaborator

Description

Add a tab.hoverBackground variable to control group tabs Floating background color

Fixes # 716

Changes

How Has This Been Tested?

2022-05-25.4.04.11.mov
  • add tab.hoverBackground to the thmem configuration file

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov

codecov Bot commented May 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #751 (c097e64) into main (05ad264) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   91.34%   91.38%   +0.04%     
==========================================
  Files         189      189              
  Lines        5947     5952       +5     
  Branches     1426     1428       +2     
==========================================
+ Hits         5432     5439       +7     
+ Misses        508      506       -2     
  Partials        7        7              
Impacted Files Coverage Δ
src/components/tabs/tab.tsx 100.00% <0.00%> (ø)
src/components/tabs/tabExtra.tsx 100.00% <0.00%> (ø)
src/workbench/sidebar/explore/folderTree.tsx 100.00% <0.00%> (ø)
src/components/tree/index.tsx 98.99% <0.00%> (+0.01%) ⬆️
src/components/breadcrumb/index.tsx 93.33% <0.00%> (+0.47%) ⬆️
src/workbench/editor/action.tsx 89.74% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ad264...c097e64. Read the comment docs.

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit 0f97d83 into DTStack:main May 25, 2022
@Zaoei Zaoei self-assigned this May 25, 2022
@Zaoei Zaoei added the bug Something isn't working label May 25, 2022
@Zaoei Zaoei added this to the 0.9.0-beta.5 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants