Skip to content

ci: improve the eslint and stylelint argvs#741

Merged
wewoor merged 2 commits into
mainfrom
ci/stylelint
May 19, 2022
Merged

ci: improve the eslint and stylelint argvs#741
wewoor merged 2 commits into
mainfrom
ci/stylelint

Conversation

@mortalYoung

Copy link
Copy Markdown
Collaborator

简介

  • 修复 ci 失败的问题

主要变更

  • 原先的 eslint 和 stylelint 命令有问题,需要用引号包裹,否则 process.argv 拿到的参数不正确
  • 修复在正确的 eslint 和 stylelint 下的一些问题,把 new-cap 改成 warn,原因是 builtin 的很多数据都是不按照规范来的,所以先改成 warn 提醒,不堵塞流程。

@mortalYoung mortalYoung self-assigned this May 18, 2022
@mortalYoung mortalYoung added the bug Something isn't working label May 18, 2022
@codecov

codecov Bot commented May 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #741 (61bc507) into main (61b1753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         189      189           
  Lines        5947     5947           
  Branches     1426     1426           
=======================================
  Hits         5432     5432           
  Misses        508      508           
  Partials        7        7           
Impacted Files Coverage Δ
src/components/tabs/tab.tsx 100.00% <ø> (ø)
src/workbench/editor/welcome/logo.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b1753...61bc507. Read the comment docs.

@wewoor wewoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor
wewoor merged commit 8692f35 into main May 19, 2022
@wewoor
wewoor deleted the ci/stylelint branch May 19, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants