feat: add built-in service#471
Merged
Merged
Conversation
mortalYoung
force-pushed
the
feat/builtin
branch
from
October 14, 2021 06:54
3bb6aa0 to
5b2ea1e
Compare
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 81.81% 85.10% +3.28%
==========================================
Files 178 179 +1
Lines 5109 5183 +74
Branches 1110 1178 +68
==========================================
+ Hits 4180 4411 +231
+ Misses 920 763 -157
Partials 9 9
Continue to review full report at Codecov.
|
mortalYoung
commented
Oct 15, 2021
mortalYoung
commented
Oct 15, 2021
Collaborator
Author
|
覆盖率达大降的原因是因为，我取消了部分 |
Collaborator
Author
终于过了 🤣 |
wewoor
requested changes
Oct 20, 2021
|
|
||
| const fileContextMenu = this.folderTreeService.getFileContextMenu(); | ||
| const folderContextMenu = this.folderTreeService.getFolderContextMenu(); | ||
| const { ROOT_FOLDER_CONTEXT_MENU } = this.builtinService.getModules(); |
Collaborator
There was a problem hiding this comment.
我们可以把 modules 和 constants 的命名区分下，不然会看起来比较奇怪，这里会怀疑获取的是一个不同的 Constant
Collaborator
Author
There was a problem hiding this comment.
确实，命名是这个 PR 里面直接改了吗，还是说另起一个 PR 改？我个人倾向于另起一个 0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
简介
主要变更