Skip to content

[BugFix][Jdbc][#1459] Remove the 'checkConnValid', because some connector doesn't support 'isValid'. #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlechazoW merged 1 commit into from
Jan 5, 2023
Merged

[BugFix][Jdbc][#1459] Remove the 'checkConnValid', because some connector doesn't support 'isValid'. #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions ...tor-jdbc-base/src/main/java/com/dtstack/chunjun/connector/jdbc/sink/JdbcOutputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@
import com.dtstack.chunjun.enums.EWriteMode;
import com.dtstack.chunjun.enums.Semantic;
import com.dtstack.chunjun.sink.format.BaseRichOutputFormat;
import com.dtstack.chunjun.throwable.ChunJunRuntimeException;
import com.dtstack.chunjun.throwable.WriteRecordException;
import com.dtstack.chunjun.util.ExceptionUtil;
import com.dtstack.chunjun.util.GsonUtil;
import com.dtstack.chunjun.util.JsonUtil;

import org.apache.flink.table.data.GenericRowData;
import org.apache.flink.table.data.RowData;
import org.apache.flink.util.FlinkRuntimeException;

import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
Expand Down Expand Up @@ -181,29 +179,6 @@ protected void writeMultipleRecordsInternal() throws Exception {
}
}

@Override
public synchronized void writeRecord(RowData rowData) {
checkConnValid();
super.writeRecord(rowData);
}

public void checkConnValid() {
try {
LOG.debug("check db connection valid..");
if (!dbConn.isValid(10)) {
if (Semantic.EXACTLY_ONCE == semantic) {
throw new FlinkRuntimeException(
"jdbc connection is valid!work's semantic is ExactlyOnce.To prevent data loss,we don't try to reopen the connection");
}
LOG.info("db connection reconnect..");
dbConn = getConnection();
stmtProxy.reOpen(dbConn);
}
} catch (Exception e) {
throw new ChunJunRuntimeException("failed to check jdbcConnection valid", e);
}
}

@Override
public void preCommit() throws Exception {
if (jdbcConf.getRestoreColumnIndex() > -1) {
Expand Down
3 changes: 2 additions & 1 deletion ...sql/src/main/java/com/dtstack/chunjun/connector/postgresql/sink/PostgresOutputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ protected void openInternal(int taskNumber, int numTasks) {
checkUpsert();
if (rowConverter instanceof JdbcColumnConverter) {
if (jdbcDialect.dialectName().equals("PostgresSQL")) {
((PostgresqlColumnConverter) rowConverter).setConnection((BaseConnection) dbConn);
((PostgresqlColumnConverter) rowConverter)
.setConnection((BaseConnection) dbConn);
}
((PostgresqlColumnConverter) rowConverter).setFieldTypeList(columnTypeList);
}
Expand Down