Private/Withdrawn badges for items everywhere#972
Merged
tdonohue merged 4 commits intoDSpace:mainfrom Jan 4, 2021
Merged
Conversation
…-everywhere Conflicts: src/app/shared/object-collection/shared/listable-object/listable-object-component-loader.component.spec.ts src/app/shared/shared.module.ts
tdonohue
approved these changes
Jan 4, 2021
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks good. I've tested it as well and it works as described. I now see private/withdrawn label in normal browsing searching (when logged in as an Admin obviously). Additionally, there's now an alert on the item page for withdrawn/private items. Thanks @Atmire-Kristof !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
This PR fixes #947
Description
This PR refactors the badges shown for withdrawn and private items on the administrative search to be shown on every listable component so that they're visible on other places as well (e.g. regular search, collection pages...)
It also adds an alert on top of simple and full item pages mentioning whether or not the item is private or withdrawn.
Instructions for Reviewers
Changes made:
ListableObjectComponentLoaderComponent.-- This component will determine whether or not the badges should be displayed (ViewMode is set to a list and the object contains
isDiscoverableand/orisWithdrawnproperties)-- The badges template is passed on to the loaded list component, which knows how to deal with the content (e.g. a grid element will place the badge in the top-left corner of the thumbnail)
ItemAlertsComponent, displaying warning alerts for private and withdrawn items and rendered on top of simple and full item pagesHow to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.