Skip to content

Hungarian language file#656

Closed
inkaweb wants to merge 2 commits intoDSpace:mainfrom
inkaweb:patch-1
Closed

Hungarian language file#656
inkaweb wants to merge 2 commits intoDSpace:mainfrom
inkaweb:patch-1

Conversation

@inkaweb
Copy link
Copy Markdown

@inkaweb inkaweb commented Apr 23, 2020

References

Add references/links to any related tickets or PRs. These may include:

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:
    • Include tests for different user types (if behavior differs), including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
    • Include tests for error scenarios, e.g. when errors/warnings should appear (or buttons should be disabled).
    • For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

Copy link
Copy Markdown
Member

@bram-atmire bram-atmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request doesn't seem to contain any changes. Could you review?

Also, can you re-issue the pull request against the catalogs that are now in the directory /src/assets/i18n and no longer in /resources/i18n?

Thank you ! Happy to help where I can.

@bram-atmire bram-atmire added the i18n / l10n Internationalisation and localisation, related to message catalogs label May 18, 2020
@tdonohue tdonohue changed the base branch from master to main July 13, 2020 21:39
@bram-atmire
Copy link
Copy Markdown
Member

Closing this pull request in favor of the more complete hungarian translation available at in #705

@bram-atmire bram-atmire closed this Feb 4, 2021
kosarko pushed a commit to ufal/dspace-angular that referenced this pull request Aug 20, 2024
* Added submission note info into workflow item view.

* Changed the czech translation for the `User's note:`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants