Merged
Conversation
tdonohue
approved these changes
Apr 1, 2020
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Tested and this fixes the issues for me. Thanks @benbosman
Merging this immediately as it's a tiny change and it fixes the broken create pages on master.
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Aug 20, 2024
… rebase (DSpace#640) * Added favicon.svg * mistype in icon --------- Co-authored-by: MajoBerger <marian.berger@dataquest.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Create community and collection was broken, this has been resolved
Instructions for Reviewers
This is just a bug fix to the create functions. Because they were at the end, the COLLECTION_CREATE_PATH was interpreted as a collection ID
Checklist
yarn run lint