Added eye icon to password field in login

[Aryakoste]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Add an "eye" icon to show the password in the login field #4988

Description

Added eye icon in password input field of login which toggles.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[AndreaBarbasso]

@Aryakoste, I feel this is the straightest approach to add some way to show the password, but it does not handle the edge cases mentioned in the linked issue:

Some browsers, such as Edge, already include this functionality natively. Therefore, we should look for a solution that is not in conflict with any (existing or future) native implementation from browsers.

Furthermore, I think that our customization should never be seen on mobile devices, since mobile browsers handle the password show/hide buttons natively.

[Aryakoste]

@AndreaBarbasso Will make the mobile device change. I had added the Microsoft edge edge case. But was confused that if i should keep native eye icon of Microsoft edge or should I show our newly added icon. Currently it shows newly added icon. So should I show native in Microsoft edge.

[Aryakoste]

I have made the changes

[github-actions]

Hi @Aryakoste,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

@Aryakoste : This PR appears to be failing automated tests. Please update the PR so that tests can succeed.

[Aryakoste]

yeah will look into it but i think the failing test is not related to this PR.

[tdonohue]

@Aryakoste : Took a more detailed look and the test failure appears to be a random failure. So, I've triggered a rerun of the tests. Hopefully they will succeed this time.

[AndreaBarbasso]

@Aryakoste, sorry if I wasn’t clear enough earlier. My concern is not about integrating the solution with Microsoft Edge’s native handling of the password field, but rather about the possibility that similar native implementations may be adopted by other browsers in the future as well.

For this reason, the code you added - while helpful for addressing the current Microsoft Edge behavior - is not future-proof with respect to other browsers (or even Edge itself, should the way it displays the eye icon change).

I think it's best to use an input group button to avoid showing our button on top of the input field, since browsers are more likely to use that placement as well for native implementations.

[Aryakoste]

Will make this change

[lgeggleston]

@Aryakoste General reminder for all new feature PRs currently under review: there is still a possibility of getting this into 10.0, in case you have the capacity to address requested changes at the moment. Feature merge deadline will be Friday 3/27. Thank you!

[Aryakoste]

Yeah will make the change today itself