Skip to content

Fix: Full item view - bitstreams continuous text overflow in full file section#4990

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
dataquest-dev:fix_bitstream_text_overflow
Mar 2, 2026
Merged

Fix: Full item view - bitstreams continuous text overflow in full file section#4990
tdonohue merged 1 commit intoDSpace:mainfrom
dataquest-dev:fix_bitstream_text_overflow

Conversation

@jr-rk
Copy link
Copy Markdown
Contributor

@jr-rk jr-rk commented Jan 12, 2026

Description

Fixes #4993

When the name of the bitstream is too long and it is continuous, it overflows through the download button. This is fixed by adding dont-break-out class to the container's class.

Before:

image

After:

image

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge component: Item (Archived) Item display or editing labels Jan 12, 2026
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jan 12, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 12, 2026
@alegontarz
Copy link
Copy Markdown

QA testing performed (no code review).

Working as expected:

  1. Bitstreams with very long, continuous file names no longer overflow the container.
  2. The file name wraps correctly and does not overlap the download button.
  3. The download button remains fully visible and clickable.

@alegontarz alegontarz moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Feb 20, 2026
@tdonohue tdonohue moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Feb 20, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jr-rk ! Code looks correct to me and I also gave it a quick test.

@tdonohue tdonohue added this to the 10.0 milestone Mar 2, 2026
@tdonohue tdonohue merged commit 6161083 into DSpace:main Mar 2, 2026
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Mar 2, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-4990-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-4990-to-dspace-7_x
git switch --create backport-4990-to-dspace-7_x
git cherry-pick -x 02780d5619cc379596f4c8c4e58d17abd9411b01

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4990-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4990-to-dspace-8_x
git switch --create backport-4990-to-dspace-8_x
git cherry-pick -x 02780d5619cc379596f4c8c4e58d17abd9411b01

@dspace-bot
Copy link
Copy Markdown
Contributor

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Mar 2, 2026

This was only able to be auto-backported to 9.x (which is all we require for bug fixes). However, if anyone wants to backport it also to 8.x or 7.x, please do so manually via a new PR.

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Mar 2, 2026
@jr-rk
Copy link
Copy Markdown
Contributor Author

jr-rk commented Mar 3, 2026

This was only able to be auto-backported to 9.x (which is all we require for bug fixes). However, if anyone wants to backport it also to 8.x or 7.x, please do so manually via a new PR.

Okay, I will manage soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Item (Archived) Item display or editing

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Long file names in the item view overlap the “Download” button

4 participants