Update legacy Bootstrap spacing class in object-list.component.html#4552
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Jul 18, 2025
tamu-sad-iii:patch-1
Merged
Update legacy Bootstrap spacing class in object-list.component.html#4552tdonohue merged 1 commit intoDSpace:mainfrom tamu-sad-iii:patch-1
tdonohue merged 1 commit intoDSpace:mainfrom
tamu-sad-iii:patch-1
Conversation
Member
|
@wwtamu : Could you please add a small description to this PR? We really shouldn't be merging anything that just has "template text" (as it's not useful to others who stumble on this PR later). :) |
Contributor
|
Hi @tdonohue, I've updated the issue text since @wwtamu and I were discussing this on Slack today and I suggested he file the issue. Thanks @wwtamu! |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
In #3506 we ported the frontend to Bootstrap v5 but missed some spacing classes that were renamed.
See: https://getbootstrap.com/docs/5.3/migration/#utilities-3
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
ml-4margin left toms-4(margin start)Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.