Migrated remaining bootstrap 4 classes & other minor css fixes

[alexandrevryghem]

References

• Related Upgrade to Bootstrap 5 & realign themes #3506

Description

Replaced the remaining bootstrap 4 classes with their matching bootstrap 5 classes. I also ran the ng generate @angular/core:control-flow command again on the whole code base to auto-fix the last remaining issues, they were all import fixes. I also fixed some other small layout issues I encountered when I went over the changes (like the bundle section from the edit bitstream page & centering the authority icon vertically in the submission form fields).

Instructions for Reviewers

List of changes in this PR:

• Replaced all the old bootstrap 4 classes with their bootstrap 5 equivalent (full migration guide)
• Ran the ng generate @angular/core:control-flow again on the whole code base, due to the lint rules there are no *ngIfs anymore, so the only changes it suggested were to import individual imports instead of the whole CommonModule for example when you only need one import from that module.

Guidance for how to test or review this PR:

• Go over the html changes and verify that everything is now fixed e.g:
  • The advanced search section should have a dropdown arrow again
  • The accessibility settings page should have proper spacing again
  • The create LDN service confirmation modal should be properly styled again
  • The pagination settings on the edit item bitstreams tab should show the whole dropdown modal even when there are very few bitstreams (e.g. only one bitstream and one bundle for example)
  • ...

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

@alexandrevryghem : This PR appears to have broken a few e2e tests. Both my-dspace.cy.ts and submission.cy.ts now have failures.

[tdonohue]

👍 Thanks @alexandrevryghem ! I gave this a test today, and did my best to test each of the modified components (to verify no odd styles or similar). It all looks good to me now.

[dspace-bot]

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-4538-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-4538-to-dspace-9_x
git switch --create backport-4538-to-dspace-9_x
git cherry-pick -x 45934e31f258221247eac7acdf1ce330ab0d0475 b4d694e0c0cf47fdb40a2e0f6c29847d7898f0fb e3b54056982e8ca120a7a99456a5fc53ef8c8eb9

[tdonohue]

@alexandrevryghem : Could you manually backport this to the dspace-9_x branch? I'm surprised it didn't backport automatically, but there must be some difference between main and dspace-9_x which is causing this PR issues.

[tdonohue]

@alexandrevryghem : If you can find time to port this to dspace-9_x, I'd love to include this in 9.1. However, 9.1 is likely coming out later this week or early next...if it misses that release, it'll have to wait for 9.2.