[Port dspace-8_x] Store the state of the computed filters#4179
Merged
tdonohue merged 3 commits intoDSpace:dspace-8_xfrom Apr 11, 2025
Merged
[Port dspace-8_x] Store the state of the computed filters#4179tdonohue merged 3 commits intoDSpace:dspace-8_xfrom
tdonohue merged 3 commits intoDSpace:dspace-8_xfrom
Conversation
12 tasks
tdonohue
approved these changes
Apr 11, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @sergius02 ! I've verified this is the same as #4121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of #4121 for DSpace dspace-8_x branch
Description
Store the state of the computed filters in the array finalFiltersComputed.
Instructions for Reviewers
The counter filtersWithComputedVisibility doesn't store the count of filters computed when you change between options in the select box in /mydspace, causing the ngIf in the HTML is always false, and no filters options render on the web.
List of changes in this PR:
How to test:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.