Fix for search facet filters disappear on MyDSpace#4162
Fix for search facet filters disappear on MyDSpace#4162FrancescoMolinaro wants to merge 3 commits intoDSpace:dspace-7_xfrom
Conversation
|
I tested this and i am sorry to say: in my 7.6.3 test installation it does not work. |
| @@ -1,7 +1,17 @@ | |||
| import { Component, Inject, Input, OnDestroy, OnInit } from '@angular/core'; | |||
| import { | |||
| AfterViewChecked, | |||
There was a problem hiding this comment.
@FrancescoMolinaro , AfterViewChecked is not used in this component.
There was a problem hiding this comment.
Hi @saschaszott , thanks for the catch and sorry was a leftover from the refactoring, should be ok now.
|
Hi @ovali , thanks for the feedback, unfortunately I can't reproduce the issue, I am using this branch with https://demo.dspace.org/ as rest: myDspace.webmCan you please provide more info on your instances or peraphs a video of the issue? Thanks in advance |
|
I am using 7.6.3 rest backend. Why you are using demo.dspace.org ? Isnt this 8.1 branch ? |
|
Hi @ovali , yes is the 8.x branch my bad, I will try to reproduce the issue with 7.6.3 locally and come back asap. |
|
I also found out : The behaviour seems to be different if you have no workflow tasks or no publications. |
|
@FrancescoMolinaro : How does this PR differ from #4121? I'm a bit confused now because we have two alternative fixes. Previously we had #4121, but it appears you've taken a different approach. Have you reviewed/tested the work already done in #4121? |
|
Hi @tdonohue thanks for the info, sorry I didn't see there was already a PR for the fix, I will check it asap and review it, if everything is ok I am going to decline this PR. |
References
Fixes issue #4097
Description
Fixed visibility computation for filters' skeleton loader
Instructions for Reviewers
The filters should not hang in a loading status indipendently from network errors or after switching from a scope to another.
List of changes in this PR:
Adapted logic to compute wheter a filter is visible or not.
To test the fix switch between configurations in MyDspace page, the filters shouldn't hang in a loading state.
(currently you can reproduce the bug on https://demo.dspace.org/ by switching configuration multiple times)
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.