No platform specific code in abstract services main#3981
Merged
tdonohue merged 4 commits intoDSpace:mainfrom Apr 3, 2025
Merged
No platform specific code in abstract services main#3981tdonohue merged 4 commits intoDSpace:mainfrom
tdonohue merged 4 commits intoDSpace:mainfrom
Conversation
This makes it possible to remove the REQUEST import from cookie.service.ts which solves a typescript issue.
…o no-platform-specific-code-in-abstract-services-main # Conflicts: # src/app/core/auth/auth.service.ts # src/app/core/auth/server-auth.service.ts # src/app/core/services/cookie.service.ts # src/app/core/services/server-cookie.service.ts
This was referenced Feb 13, 2025
tdonohue
approved these changes
Apr 3, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @AAwouters ! I reviewed and tested this today, and I'm not noticing any changes in behavior. Code looks good too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Moves platform-specific imports out of the abstract Cookie- and AuthService and moves them to ServerCookie- and ServerAuthService.
Instructions for Reviewers
This PR does not directly produce an observable difference.
It does solve the problem mentioned in #3974.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.