Skip to content

3057 - The "Register DOI" button on the Item status page is not displ…#3058

Closed
aroman-arvo wants to merge 1 commit intoDSpace:dspace-7_xfrom
arvoConsultores:3057
Closed

3057 - The "Register DOI" button on the Item status page is not displ…#3058
aroman-arvo wants to merge 1 commit intoDSpace:dspace-7_xfrom
arvoConsultores:3057

Conversation

@aroman-arvo
Copy link
Copy Markdown
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

Bug returning array

Instructions for Reviewers

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug identifiers: DOIs 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release labels May 16, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 16, 2024
@tdonohue tdonohue self-requested a review May 16, 2024 13:49
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Jun 5, 2024

Closing, as this fix was already applied to dspace-7_x in #2802 (which was a port of #2766). You can see this change in this PR already exists in the dspace-7_x branch here: https://github.com/DSpace/dspace-angular/blob/dspace-7_x/src/app/item-page/edit-item-page/item-status/item-status.component.ts#L190

So, this PR is obsolete/outdated as the fix has been applied

@tdonohue tdonohue closed this Jun 5, 2024
@tdonohue tdonohue added duplicate and removed port to main This PR needs to be ported to `main` branch for the next major release labels Jun 5, 2024
@tdonohue tdonohue removed this from the 8.0 milestone Jun 5, 2024
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug duplicate identifiers: DOIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants