Fix handle redirect not working with custom nameSpace#2630
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Nov 13, 2023
Merged
Conversation
tdonohue
approved these changes
Nov 13, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Tested this locally and verified it works for custom ui.nameSpace values (as well as for the default value of /). Code looks good too.
Contributor
|
Successfully created backport PR for |
dsteelma-umd
added a commit
to dsteelma-umd/mdsoar-angular
that referenced
this pull request
Jan 18, 2024
In LIBCIR-316, the DSpace code was customized to redirect "handle" URLs in such a way that the browser "Back" button properly returned to the original page. Code changes in DSpace 7.6 in the following commit/pull request: * DSpace/dspace-angular@d4a5308 * DSpace/dspace-angular#2630 appear to make that customization no longer necessary (they also break the current customization). Restored the code changed in LIBCIR-316 to the DSpace 7.6.1 stock code. https://umd-dit.atlassian.net/browse/LIBCIR-368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixed a bug in
DsoRedirectServicewhich caused the service to redirect the user to the wrong page when a customui.nameSpaceis set.Instructions for Reviewers
List of changes in this PR:
DsoRedirectServiceto add the baseHref/nameSpace in front of absolute routes.Guidance for how to test or review this PR:
ui.nameSpaceto for example/dspace-angularthe handle redirect still works when you go to/dspace-angular/handle/{handle}and that it redirects you to the correct dso page/Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.