Move subscription button to DSO edit menu

[ybnd]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Subscription button should be moved to the DSO menu #2384
• Aligns Manage Subscriptions interface #2017 with Replace dso page edit buttons with a menu #1852

Description

This PR removes the ds-dso-page-subscription-button component and replaces it with an entry in the DSO edit menu for Communities and Collections.

Reviewing

1. Run DSpace Angular at this PR's branch locally
2. Log in to DSpace
3. Go to any Community or Collection page
   • You should see the subscription bell button, now part of the DSO edit menu
   • It should work exactly as before -- open the subscription modal

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[ybnd]

Integration tests failed on /mydspace, which seems entirely unrelated to the changes here.

1) My DSpace page
       should let you import from external sources:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `button[data-test="import-dropdown"]`, but never found it.
      at Context.eval (webpack:///./cypress/e2e/my-dspace.cy.ts:144:11)

[alanorth]

Thanks @ybnd. To be clear, visually, there is no difference in where the subscription bell appears or how works.

I tested this patch on DSpace 7.6 and found it to be anti-climactic because it looks and behaves exactly as before. 👍 I confirmed that after applying the patch I no longer see the ds-dso-page-subscription-button component in the DOM, and the bell icon works exactly as before.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Move subscription button to DSO edit menu #2528