Skip to content

Fix for related item thumbnail images.#1987

Merged
tdonohue merged 4 commits intoDSpace:mainfrom
mspalti:relation-submisssion-thumb
Dec 19, 2022
Merged

Fix for related item thumbnail images.#1987
tdonohue merged 4 commits intoDSpace:mainfrom
mspalti:relation-submisssion-thumb

Conversation

@mspalti
Copy link
Copy Markdown
Member

@mspalti mspalti commented Dec 3, 2022

References

Description

Fixes problem with missing thumbnails and bad placeholder layouts for relationships in submission forms.

List of changes in this PR:

  • Added thumbnail follow link for related item lookups
  • Modified html template for ds-existing-relation-list-element to fill entire row regardless of how much text is shown in the item metadata.

Screen Shot 2022-12-03 at 2 08 28 PM

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@mspalti mspalti self-assigned this Dec 3, 2022
@tdonohue tdonohue added bug component: submission high priority 1 APPROVAL pull request only requires a single approval to merge labels Dec 5, 2022
@tdonohue tdonohue added this to the 7.5 milestone Dec 5, 2022
@tdonohue tdonohue requested review from tdonohue and ybnd December 8, 2022 15:58
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mspalti ! I tested this today and this fixes the bug. Tested with the Person submission form and verified that both a Publication with a thumbnail and without a thumbnail appears properly when linked to the person.

@tdonohue tdonohue merged commit fa2dc72 into DSpace:main Dec 19, 2022
@mspalti mspalti deleted the relation-submisssion-thumb branch October 13, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission high priority

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Thumbnails in submission forms rendered incorrectly

2 participants