Minor fixes related to line breaks & Markdown in metadata fields#1925
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Oct 28, 2022
Merged
Minor fixes related to line breaks & Markdown in metadata fields#1925tdonohue merged 3 commits intoDSpace:mainfrom
tdonohue merged 3 commits intoDSpace:mainfrom
Conversation
The Markdown parser generates HTML with headings, paragraphs, ... for each bit of text. This results in extra vertical spacing if we use `white-space: pre-line`
Member
Author
|
The e2e failures seem entirely unrelated to the changes here, so I'm hoping they're random. |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jul 8, 2024
[DSC-1708] popover width adjustment Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR bundles a few minor fixes related to #1851
Even spacing between comma-separated MDVs (e.g. subjects)

This was an older issue, caused by line breaks within the
<span>, which Angular translates into unwanted spacing. Now we include a space in the separator itself:', 'Made
enableMarkdownan input ofds-generic-item-page-fieldso it's easier to enable Markdown for arbitrary Item page fieldsWhen the new
dsMarkdownpipe is combined with the new.preserve-line-breaksCSS class, line breaks in Markdown are effectively doubled. Therefore, we shouldn't add this class when rendering Markdown.Instructions for Reviewers
Confirm that this PR solves the issues listed above and that the changes are sensible.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.