Skip to content

repair tests bis#1872

Merged
tdonohue merged 4 commits intoDSpace:mainfrom
atmire:w2p-93963-Add_support_for_line_breaks_markdown_and_mathjax_in_metadata
Sep 30, 2022
Merged

repair tests bis#1872
tdonohue merged 4 commits intoDSpace:mainfrom
atmire:w2p-93963-Add_support_for_line_breaks_markdown_and_mathjax_in_metadata

Conversation

@samuelcambien
Copy link
Copy Markdown
Contributor

@samuelcambien samuelcambien commented Sep 30, 2022

This is a continuation of #1851.
This PR is merged already, but apparently the code causes test failures sometimes.
I've updated the tests so they are more stable and should no longer fail now.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 30, 2022

This pull request introduces 2 alerts when merging 2c74888 into 6f9d310 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@samuelcambien samuelcambien force-pushed the w2p-93963-Add_support_for_line_breaks_markdown_and_mathjax_in_metadata branch 3 times, most recently from c1c9614 to fecb597 Compare September 30, 2022 12:56
@tdonohue tdonohue added bug testing framework Related specifically to Unit or Integration (e2e) Tests labels Sep 30, 2022
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Sep 30, 2022

@samuelcambien : It looks like the updated tests are failing still. Nonetheless, I'll pull this over to our board in the hopes you'll find a fix. I'll gladly review this once it's ready.

@samuelcambien samuelcambien force-pushed the w2p-93963-Add_support_for_line_breaks_markdown_and_mathjax_in_metadata branch from fecb597 to 80500e7 Compare September 30, 2022 14:10
@tdonohue tdonohue mentioned this pull request Sep 30, 2022
Merged
6 tasks
@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Sep 30, 2022

@samuelcambien : It looks like you are working on this, but just noting that the tests all have NullInjectorError: No provider for InjectionToken APP_CONFIG! If it helps, you can run these tests locally first by just running yarn test to verify they are working on your end.

@samuelcambien samuelcambien force-pushed the w2p-93963-Add_support_for_line_breaks_markdown_and_mathjax_in_metadata branch from 80500e7 to 8a6ff75 Compare September 30, 2022 15:06
@tdonohue tdonohue added this to the 7.4 milestone Sep 30, 2022
tdonohue
tdonohue approved these changes Sep 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @samuelcambien & @LotteHofstede ! These changes look good to me & they seem to have fixed the random spec failures (at least so far they don't seem to be occurring).

I'll merge this in the hopes that it fixes the problem for other affected PRs.

@tdonohue tdonohue merged commit 1779b1f into DSpace:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@samuelcambien samuelcambien

Labels

bug testing framework Related specifically to Unit or Integration (e2e) Tests

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@samuelcambien @tdonohue @LotteHofstede