Make no. of communities per pagination / expansion configurable

[mark-cooper]

References

• Resolves Make the number of communities on the home page configurable #1749
• Resolves Make the number of communities in the Browse by Community page configurable #1750

Description

Adds new config settings for no. of communities to display on the
home page & community-list page.

Instructions for Reviewers

Compare result of updating the config, for example:

browseCommunities:
  communityListPageSize: 25
  topLevelPageSize: 10

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[artlowel]

Thanks @mark-cooper!

This works the way it should, I just have a few inline comments on the code. One strange thing I also noticed in the other RPP PR (#1771), is that no matter what you set the topLevelPageSize to, it will always round to the nearest number from the list of page sizes. e.g. if you set it to 7 it'll use 10.

It would be good to add a comment above the param in the example config to let people know about that

[mark-cooper]

@artlowel thx for the feedback. I'm not sure if the convention is to have the PR author or reviewer resolve conversations so I'll leave it for you.

[tdonohue]

@mark-cooper : Quick comment...Could we change this to say homePage:? We have a different PR (#1801) which is creating a section called homePage and it'd be good to align these two PRs so that we have a single section for all homepage configs.

It's unclear which PR will be ready to merge first, but both PRs also have a homepage-config.interface.ts sort of file...and we'll need to find a way to merge the two together.

[mark-cooper]

@tdonohue no problem! Also I updated things to be more aligned with #1801 so there's less to do bringing them together.

[artlowel]

Thanks @mark-cooper!

[tdonohue]

@mark-cooper : I just merged #1801 , which was the PR that overlapped slightly with this one in terms of the homePage configuration section. Could you rebase this PR now on main to resolved the conflicts? It should also simplify this PR as the homepage-config.interface.ts already exists on main now and you'll just need to update it.

Once this is rebased, I'll do a final test & then this will be ready to merge

[mark-cooper]

@tdonohue updated!

[tdonohue]

👍 Thanks @mark-cooper ! I gave this one final test after the conflict cleanup, and it's still working perfectly. Code looks good too