Skip to content

Add delete process functionality#1792

Merged
tdonohue merged 5 commits intoDSpace:mainfrom
atmire:w2p-93914_delete-process
Sep 7, 2022
Merged

Add delete process functionality#1792
tdonohue merged 5 commits intoDSpace:mainfrom
atmire:w2p-93914_delete-process

Conversation

@YanaDePauw
Copy link
Copy Markdown
Contributor

@YanaDePauw YanaDePauw commented Aug 25, 2022

References

Description

This PR contains functionality to delete processes.

On a process page, a delete button has been added that will delete the current process and navigate the user back to the overview page.

On the overview page, a trash bin icon has been added that can be clicked to toggle a process for deletion. This allows a user to select a bunch of processes for deletion. When 1 or more processes are selected, a button will be shown to delete all the processes.

Instructions for Reviewers

To test the individual process deletion, perform the following steps:

  • Navigate to a process detail page
  • Click the delete button
  • Confirm the delete in the popup
  • Verify that you are navigated to the overview page and that the process has been deleted

To test the bulk process deletion, perform the following steps:

  • Navigate to the process overview page
  • Click the trash icon for different processes on different pages
  • Verify that the delete button contains a count of all selected processes
  • Click the delete button
  • Confirm the delete in the popup
  • When the deletion is in progress the popup will remain to prevent the user from deleting the same processes or navigating to processes that are being deleted
  • Upon completion, verify that the popup closes and a notification is shown containing the number of successful deletes
  • When a deletion fails, a separate error notification is shown for the failed process

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 25, 2022

This pull request introduces 1 alert when merging d5605e4 into 9a5a7c1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@tdonohue tdonohue requested review from abollini and tdonohue August 25, 2022 14:54
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 25, 2022

This pull request introduces 1 alert when merging 72852dd into 9a5a7c1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@tdonohue tdonohue requested a review from atarix83 September 1, 2022 14:29
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @YanaDePauw for this PR

it looks good to me and it works fine

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @YanaDePauw ! The code here looks good, and I tested it today and it works well.

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Sep 7, 2022

Merging as this is at +2 approvals

@tdonohue tdonohue merged commit cd1d409 into DSpace:main Sep 7, 2022
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Jun 10, 2024
[DSC-1759] navbar-search in mobile screen fix

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for Processes to be deleted from the User Interface Addition of button to delete a single process

4 participants