Add delete process functionality#1792
Merged
tdonohue merged 5 commits intoDSpace:mainfrom Sep 7, 2022
Merged
Conversation
|
This pull request introduces 1 alert when merging d5605e4 into 9a5a7c1 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 72852dd into 9a5a7c1 - view on LGTM.com new alerts:
|
atarix83
approved these changes
Sep 7, 2022
Contributor
atarix83
left a comment
There was a problem hiding this comment.
thanks @YanaDePauw for this PR
it looks good to me and it works fine
tdonohue
approved these changes
Sep 7, 2022
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @YanaDePauw ! The code here looks good, and I tested it today and it works well.
Member
|
Merging as this is at +2 approvals |
6 tasks
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jun 10, 2024
[DSC-1759] navbar-search in mobile screen fix Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR contains functionality to delete processes.
On a process page, a delete button has been added that will delete the current process and navigate the user back to the overview page.
On the overview page, a trash bin icon has been added that can be clicked to toggle a process for deletion. This allows a user to select a bunch of processes for deletion. When 1 or more processes are selected, a button will be shown to delete all the processes.
Instructions for Reviewers
To test the individual process deletion, perform the following steps:
To test the bulk process deletion, perform the following steps:
Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.