Skip to content

Fix issue where the themed submission page would crash #1077

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:fix-themed-submission
Mar 29, 2021
Merged

Fix issue where the themed submission page would crash #1077
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:fix-themed-submission

Conversation

@artlowel
Copy link
Copy Markdown
Member

References

Description

After #1042 was merged the submission page would crash when creating a new submission, due to a mistake in the component name in ThemedSubmissionSubmitComponent

Instructions for Reviewers

Using this PR the submission should no longer crash, with or without a theme.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added high priority 1 APPROVAL pull request only requires a single approval to merge labels Mar 29, 2021
@artlowel artlowel added this to the 7.0beta5 milestone Mar 29, 2021
@artlowel artlowel requested a review from tdonohue March 29, 2021 15:15
@artlowel artlowel self-assigned this Mar 29, 2021
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @artlowel ! This looks correct & I also tested it locally and it fixes the issue.

@tdonohue tdonohue merged commit 436b952 into DSpace:main Mar 29, 2021
@artlowel artlowel deleted the fix-themed-submission branch March 31, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants