-
Notifications
You must be signed in to change notification settings - Fork 530
Check relationship.effects.spec.ts after Angular 10 upgrade #993
Description
During Angular 10 upgrade the relationship.effects.spec.ts has been redesign because it used a spy on rxjs's debounceTime operator and due to jasmine update this is not possible. To allow to test with asynchronous operator we replaced the use of spy with the more appropriate TestScheduler function. It works for almost all class's tests, with the exception of a few which required to be reviewed by comparing them with the implementation. It is likely, in fact, that previously the tests were successful only because the specs had no expectations. Here the link to the tests that need a review :
https://github.com/4Science/dspace-angular/blob/main/src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.spec.ts#L142
https://github.com/4Science/dspace-angular/blob/main/src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.spec.ts#L213
https://github.com/4Science/dspace-angular/blob/main/src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.spec.ts#L234