Conversation
tdonohue
left a comment
There was a problem hiding this comment.
@benbosman : Overall this contract looks good to me. A few minor questions/improvements noted inline.
…ot specific to versioning
tdonohue
left a comment
There was a problem hiding this comment.
@benbosman : Thanks for the updates. 👍 Overall, I think this looks good now. A very minor comment below about some missing status codes. But beyond that, I think this is ready to be merged.
|
Thanks @tdonohue for the review. I've included the status codes, they are indeed correct |
abollini
left a comment
There was a problem hiding this comment.
it looks good, just a few notes inline to followup our convention for the URL structure
abollini
left a comment
There was a problem hiding this comment.
there are still some url in the single endpoints and in the examples that are in the singolar form.
Please take a look to my additional reply to the "subpath / search method / redirect" discussions as well
abollini
left a comment
There was a problem hiding this comment.
Thanks @benbosman to address my feedback! it is ready to go for me
tdonohue
left a comment
There was a problem hiding this comment.
👍 The updates look good to me too. Thanks @benbosman
First iteration of the read-only parts of versioning, planned for beta 2
This will allow displaying the version history