Fix "undefined" Tooltip Messages

[aaronskiba]

Fixes #3361

• constants.js Returning Undefined For Some Keys #3361

Changes proposed in this PR:

• Prior to this change, asterisk was evaluating to undefined. Moving getConstant('REQUIRED_FIELD_TEXT') inside of the requiredField.js jQuery callback ensures that REQUIRED_FIELD_TEXT will be loaded before getConstant() attempts to retrieve it.
• The constant, VALIDATION_MESSAGE_PASSWORDS_MATCH was previously removed (here). However, this PR puts the constant back, because getConstant('VALIDATION_MESSAGE_PASSWORDS_MATCH') is executed in passwordHelper.js.

[gjacob24]

Hi @aaronskiba I have a question about where the constant VALIDATION_MESSAGE_PASSWORDS_MATCH is used in the code. I presume it's when you reset your password but I see a different message when I try to save mismatched passwords. Can you tell me how to test if the constant is used as expected please? Thanks!

[aaronskiba]

Hi @aaronskiba I have a question about where the constant VALIDATION_MESSAGE_PASSWORDS_MATCH is used in the code. I presume it's when you reset your password but I see a different message when I try to save mismatched passwords. Can you tell me how to test if the constant is used as expected please? Thanks!

Hi @gjacob24,

Sorry for slow reply on this one. Also, this constant is a bit tricky to test locally, but here's one way.

1. On the sign-in page, click the Forgot password? link.
2. Enter an email that exists within your local db, and click send.
3. No email will be sent to you. However, you can find a link within the terminal. Here's what mine looks like:

  <p>
    Hello super_admin@example.com
  </p>
  <p>
    Someone has requested a link to change your DMPRoadmap password. You can do this through the link below.
  </p>
  <p><a href="http://Aarons-Mac-mini/users/password/edit?reset_password_token=XpnsHx1Hwkqgx1yZzRbq">Change my password</a></p>

4. Replace the host with 127.0.0.1:300 and navigate to that link (e.g. 127.0.0.1:3000/users/password/edit?reset_password_token=XpnsHx1Hwkqgx1yZzRbq)
5. Enter mismatching passwords and click 'Save'. The The passwords must match. message should render.

[gjacob24]

Hi @aaronskiba, thank you for explaining how to test the second one. Glad I asked because I noticed this page needed some polishing after the Bootstrap upgrade.
Anyway, I have tested both your code changes now. It works as expected and can be merged.

[gjacob24]

Both code changes work as expected. This PR can be merged into the development branch for the upcoming release.

[aaronskiba]

Both code changes work as expected. This PR can be merged into the development branch for the upcoming release.

Great to hear, thank you. Also, I finally added/committed a changelog entry for this one as well. :)

[gjacob24]

Great to hear, thank you. Also, I finally added/committed a changelog entry for this one as well. :)

Great, ok. I was going to suggest adding change log entries together in one commit for your PRs but I guess this is better. Thanks!