Fix logical address scanning and preserve failure history - #49
Merged
Conversation
This was referenced Jul 27, 2026
randomblocker
marked this pull request as ready for review
July 28, 2026 16:50
Keep both new store tables: artifact_failure_history (this PR, survives chain resets) and listing_rejections (#57, cleared on reset). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The scanner previously matched the first 40 hex characters inside a 64-hex logical bundle address. It then queried that fabricated locator and produced misleading
STORAGE_UNREADABLEdead letters. Chain replacement cleanup also deleted the only copy offirstSeenAt, making old failures look newly discovered after every rebuild.This change separates native-locator discovery from logical bundle resolution and separates active retry state from historical operator telemetry.
Follow-up
Persistent failure history needs a retention ceiling because arbitrary chain transactions can advertise fabricated locators. This non-blocking follow-up is tracked in #51.
Closes #45.
Closes #46.
Validation
npm run typechecknpm test— 131/131npm run build