fix(try): correct Demos explorer links + simplify the Oracle input form#41
Draft
randomblocker wants to merge 2 commits into
Draft
fix(try): correct Demos explorer links + simplify the Oracle input form#41randomblocker wants to merge 2 commits into
randomblocker wants to merge 2 commits into
Conversation
Two fixes to the Try DACS page from user feedback.
1. Transaction links were 404ing. The Demos explorer serves transactions at
/transactions/<hash>, not /tx/. Fixed every ${EXPLORER}/tx/ link across the
directory (TryDacs, TryChat, HomeDealDemo, and the deal page). BaseScan/x402
links keep /tx/ (that's BaseScan's path).
2. "Where you enter variables is too confusing." The Oracle form exposed a raw
key/value grid ("Product parameters", id=bitcoin) — the buyer had to know the
param key names. Replaced it with plain labeled fields per product:
- crypto-price -> a single "Coin" field (bitcoin / ethereum / …)
- fx-rate -> "From currency" / "To currency"
- chain-height -> no inputs, just a short note
The product dropdown now uses human labels too. Same submitted object; the
KeyValueEditor is no longer used by this form.
Touched files typecheck clean; no new errors (the repo's pre-existing
@kynesyslabs/dacs subpath resolution errors in a bare checkout are unrelated).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The try-chat regression test pinned the old /tx/ Demos explorer URL (which 404s). Update it to the corrected /transactions/ path to match the link fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to
/tryfrom user feedback.1. Transaction links were broken (404)
The Demos explorer serves transactions at
/transactions/<hash>, not/tx/. Every${EXPLORER}/tx/link in the directory pointed at a 404. Fixed acrossTryDacs,TryChat,HomeDealDemo, and the deal page. BaseScan / x402 links keep/tx/(that's BaseScan's path).Verified:
https://explorer.demos.sh/tx/<hash>→ 404,https://explorer.demos.sh/transactions/<hash>→ 200.2. "Where you enter variables is too confusing"
The Oracle form exposed a raw key/value grid ("Product parameters",
id=bitcoin) — the buyer had to know the internal param key names. Replaced with plain labeled fields per product:id=bitcoin)The product dropdown now uses human labels ("Crypto price (a coin in USD)" …). Same object is submitted to the gateway;
KeyValueEditoris just no longer used by this form.Verification
Touched files are typecheck-clean;
AgentInputFormcompiles in isolation. (A bare checkout has pre-existing@kynesyslabs/dacssubpath-resolution errors unrelated to this change — CI has those deps built.)Note
This is a first pass on the simplification — starting with the worst offender (Oracle params). Happy to extend the same treatment to the DD/Security forms, the rail picker, or the governance disclosure based on feedback.
🤖 Generated with Claude Code