Filter operator runs forver if given an inifnite list

[kirjorjos]

Issue type:

• 🐛 Bug

---

Short description:

Using filter on an infinite list causes world hang, similar to #1582

Steps to reproduce the problem:

1. Make a lazy built infinite list, lazyBuilt(1, apply(addition, int 1)) for example
2. make a predicate that the list can be filtered by, pipe(apply(flip(modulo), int 2), apply(relationalEquals, int 0) for example
3. filter the infinite list
4. world hangs

Expected behaviour:

Some sort of time out or max index

---

Versions:

Common Capabilities: 2.9.7
Cyclops Core: 1.20.1
Integrated Dynamics: 1.29.1
Minecraft: 1.19.2
Mod loader version: Forge 43.4.6

Log file:

[rubensworks]

Thanks for reporting!

[kirjorjos]

Also noticed it with list equals (multi) set, and itemstack list count (practical way someone might get a lazy list of items is maping a list of unames over item by name)

Also, slightly related, but I'll open a new issue if you want me to, I noticed that relational equals given 2 Infinite Lists instantly returns false if the var ids differ, but unless I'm mistaking, only 4 things need to be checked for equality: initial value, generator operator, overall map operator, and any appended values. Not sure if this would be closer to a feature request or bug report though.

[rubensworks]

Also, slightly related, but I'll open a new issue if you want me to, I noticed that relational equals given 2 Infinite Lists instantly returns false if the var ids differ, but unless I'm mistaking, only 4 things need to be checked for equality: initial value, generator operator, overall map operator, and any appended values. Not sure if this would be closer to a feature request or bug report though.

This would be very difficult to support, as we'd need to handle equality over the full pipeline of operators (including partially applied operators). It's possible, but a lot of work. Given it's a very exotic edge-case, it will probably be very low on my to-do-list. But you're welcome to open a feature request for it.