-
-
Notifications
You must be signed in to change notification settings - Fork 78
1.5 deprecate tools #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5 deprecate tools #316
Conversation
09a627d to
728f900
Compare
src/main/java/org/cyclonedx/util/deserializer/AttachmentTextDeserializer.java
Show resolved
Hide resolved
src/main/java/org/cyclonedx/util/deserializer/PropertyDeserializer.java
Outdated
Show resolved
Hide resolved
0e15639 to
5df8407
Compare
src/main/java/org/cyclonedx/util/deserializer/ResolvesDeserializer.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-core-java/316.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-core-java/316.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
336a9e7 to
2dcef05
Compare
1cbce5c to
a08c5a4
Compare
00f64c4 to
f402906
Compare
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
Signed-off-by: Alex Alzate <[email protected]>
f402906 to
ab72ef0
Compare
This deprecates the `Tool` class in favor of `ToolInformation`, see [1]. [1]: CycloneDX/cyclonedx-core-java#316
|
For the record, the deprecation of the |
|
@sschuberth Java doesn't distinguish between specification vs implementation deprecation. A field/method is either deprecated or its not. In the case of the specification, the use of tools is deprecated and will be removed in CycloneDX v2.0, therefore we've deprecated the implementation supporting it. You may want to experiment, but it may be possible to write out 1.4 BOMs via reflection, rather than calling the methods directly. This may work around the deprecation warnings, but I'm not entirely sure. |
This deprecates the `Tool` class in favor of `ToolInformation`, see [1]. [1]: CycloneDX/cyclonedx-core-java#316
This deprecates the `Tool` class in favor of `ToolInformation`, see [1]. [1]: CycloneDX/cyclonedx-core-java#316
This PR has changed for the deprecation of tools, I had to introduce different Deserializers to make it work correctly since I had to deserialize the Metadata to make sure only the right info was loaded based on the schema definition.
Tools still have precedence over components/services if it's present.