Various fixes (Beta 1.8-1.8.9 spawnpoint bug, preprocesser #define guards, etc.)#133
Open
Nel-S wants to merge 1 commit intoCubitect:masterfrom
Open
Various fixes (Beta 1.8-1.8.9 spawnpoint bug, preprocesser #define guards, etc.)#133Nel-S wants to merge 1 commit intoCubitect:masterfrom
Nel-S wants to merge 1 commit intoCubitect:masterfrom
Conversation
- Beta 1.8 - 1.8.9 spawn first-stage fallback is (0,0), not (8,8) - Added #ifdef/#undef guards in case any #define'd keywords were already previously defined (an error occurs otherwise) - change stronghold chunk offset to (0,0) to match /locate coordinate - change 1.18+ second-stage spawn estimate chunk offset to (0,0) to match most likely coordinate pick - update Readme spawn description for 1.18+, plus add basic Windows instructions and makefile debugging information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STRUCTorUNREACHABLEwere already defined (for example, if a user's program includes a different library with that keyword followed by this one, which happened to me), the compilation encounters an error. I added #ifdef/#undef guards to undefine the previous keywords and so avoid the collisions.make cleanfor anyone who encounters errors (like I did the first time I tried to use that).These, meanwhile, will probably be the most controversial changes:
estimateSpawn();getSpawn()is not affected by the change.