This repository was archived by the owner on Apr 14, 2025. It is now read-only.
Fixed an issue to make sure all the top level categories are selected from aws rekognition response#67
Merged
Merged
Conversation
…aws, this improves on the existing solution of only looking for the top-level category in Label.ParentName, this is achieved by lookin at both ParentName and Name
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 4 4
Lines 336 336
Branches 94 94
=======================================
Hits 186 186
Misses 70 70
Partials 80 80 |
Comment on lines
+17
to
+20
| match self.ParentName.is_empty() { | ||
| true => &self.Name, | ||
| _ => &self.ParentName, | ||
| } |
Contributor
There was a problem hiding this comment.
Please change this to an if else
| .iter() | ||
| .map(|l| l.ParentName.clone()) | ||
| .map(|l| l.top_category().to_owned()) | ||
| .filter(|l| !l.is_empty()) |
Contributor
There was a problem hiding this comment.
Is this line necessary since a empty check is occurring in the top_category fn?
bhaskarkishore
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a function to the implementation of Label for correctly getting the top-level category returned by aws, this improves on the existing solution of only looking for the top-level category in Label.ParentName, by looking at both ParentName and Name