Skip to content

Update create_ioc.py#175

Merged
jshcodes merged 1 commit into
CrowdStrike:mainfrom
aneisch:patch-1
Jun 24, 2021
Merged

Update create_ioc.py#175
jshcodes merged 1 commit into
CrowdStrike:mainfrom
aneisch:patch-1

Conversation

@aneisch

@aneisch aneisch commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

Update field names to match new API, otherwise some fields are not properly filled in the UI

Update IOCs example

  • Documentation

Unit test coverage

COVERAGE TESTING NOT REQUIRED FOR SAMPLE SUBMISSIONS

Bandit analysis

[main]	INFO	running on Python 3.8.5
Run started:2021-06-24 16:48:50.329455

Test results:
	No issues identified.

Code scanned:
	Total lines of code: 767
	Total lines skipped (#nosec): 0

Run metrics:
	Total issues (by severity):
		Undefined: 0.0
		Low: 0.0
		Medium: 0.0
		High: 0.0
	Total issues (by confidence):
		Undefined: 0.0
		Low: 0.0
		Medium: 0.0
		High: 0.0
Files skipped (0):

Issues resolved

  • Fixed: Field name mismatches

Update field names to match new API, otherwise some fields are not properly filled in the UI
@jshcodes jshcodes self-requested a review June 24, 2021 16:48
@jshcodes jshcodes self-assigned this Jun 24, 2021
@jshcodes

Copy link
Copy Markdown
Member

Most unit tests workflows will fail at this point due to an access issue with the repo secret. Approving this so it can be tested as part of the push.

@jshcodes jshcodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't notice that when I swapped the payload format.

Thank you! 😃

@jshcodes jshcodes merged commit 91c802c into CrowdStrike:main Jun 24, 2021
@jshcodes jshcodes added the code samples Functioning sample code to get you started label Jun 24, 2021
@aneisch aneisch deleted the patch-1 branch June 24, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code samples Functioning sample code to get you started

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants