Update create_ioc.py#175
Merged
Merged
Conversation
Update field names to match new API, otherwise some fields are not properly filled in the UI
Member
|
Most unit tests workflows will fail at this point due to an access issue with the repo secret. Approving this so it can be tested as part of the push. |
jshcodes
approved these changes
Jun 24, 2021
jshcodes
left a comment
Member
There was a problem hiding this comment.
Good catch, I didn't notice that when I swapped the payload format.
Thank you! 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update field names to match new API, otherwise some fields are not properly filled in the UI
Update IOCs example
Unit test coverage
Bandit analysis
[main] INFO running on Python 3.8.5 Run started:2021-06-24 16:48:50.329455 Test results: No issues identified. Code scanned: Total lines of code: 767 Total lines skipped (#nosec): 0 Run metrics: Total issues (by severity): Undefined: 0.0 Low: 0.0 Medium: 0.0 High: 0.0 Total issues (by confidence): Undefined: 0.0 Low: 0.0 Medium: 0.0 High: 0.0 Files skipped (0):Issues resolved