Write extension sources into an Extensions subdirectory#141
Merged
liamnichols merged 2 commits intomainfrom Aug 15, 2022
Merged
Write extension sources into an Extensions subdirectory#141liamnichols merged 2 commits intomainfrom
liamnichols merged 2 commits intomainfrom
Conversation
Contributor
|
Think it looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the 0.1 generator out, I decided that I wasn't quite a fan on having extensions left in the top-level of the output directory since it made things look a little messy and disorganised.
Instead, I'm proposing that we nest them in their own directory named Extensions to keep things a little more organised.
I also think this aligns a bit better with how other generators work, for example the
openapi-generatordoes this (for Android):WDYT @LePips? When generating with
mergeSources, they'll continue to be embedded inside Paths.swift and Entities.swift