2466 waveform tweaks#2473
Merged
kasemir merged 3 commits intoAug 13, 2018
Merged
Conversation
kasemir
approved these changes
Aug 10, 2018
kasemir
added a commit
to kasemir/org.csstudio.display.builder
that referenced
this pull request
Aug 13, 2018
kasemir
added a commit
to ControlSystemStudio/phoebus
that referenced
this pull request
Aug 13, 2018
Import of ControlSystemStudio/cs-studio#2473, but not using CheckMenuItem because it didn't "look" right. Displays only a check mark, so in non-selected state there's no empty checkbox. Just " Show XXX" without an empty checkbox suggests that XXX should be shown, when in fact the option is _not_ selected --> Staying with the code that updates label and/or graphics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes / suggestions:
cc @skyfrench