SNS: Fix logbook 'title' length overrun#173
Merged
Merged
Conversation
logbook API doesn't support title per se. SNS implementation uses first line as title, and that could create an overrun. Now 'title' is shortened.
Member
|
Are you sure you don't need this for 3.2.x; I would consider this a bug fix |
berryma4
added a commit
that referenced
this pull request
Oct 23, 2013
…e_length SNS: Fix logbook 'title' length overrun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logbook API doesn't support title per se.
SNS implementation uses first line as title, and that could create an
overrun.
Now 'title' is shortened.