Intermittent failure in diirt unit tests

[nickbattam]

We have been seeing intermittent failures of the unit tests in diirt, building the 4.3 branch:

diirt_test_failure.txt

Rerunning the build on the same hardware straight after both of these failures the unit tests passed successfully.

[kasemir]

Are the expected values in the test simply too "tight"?

[shroffk]

Hi Nick, I have been having trouble reproducing these...
Can you give me some information n the environment you are running them on?

[shroffk]

Never mind, got it to reproduce...looking into it now.

[nickbattam]

@shroffk For the record the failures are happening on master as well as the 4.3 branch.

[shroffk]

ya, this has nothing to do with recent changes. The error is due to how the nano part of the time instant is handled by the different time related objects (Duration & TimeInterval)

[shroffk]

@kasemir The idea of the test is to ensure that the simulated updated arrives with the exact timestamp.

To me the problem seemed to be how the replay was calculating the offset...both the ReplayTest and the Replay class create a reference instant now(), when this instance differs by more than a ms the test fails.
So instead I think it is best to calculate the offset for the events from the TimeInterval supplied to the create value. This way we still get values with the exact timestamp as specified in the file.

[nickbattam]

@shroffk I've run a number of diirt builds with the ControlSystemStudio/diirt@1113680 patch and it resolves the Replay test failure.
I can still reproduce the ErrorHandlingTest failure:

exceptionInFunction(org.diirt.datasource.sim.ErrorHandlingTest) Time elapsed: 1.01 sec <<< FAILURE!