fix #491: read() returns ReadResult with ReadStatus instead of silent#497
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Mar 9, 2026
Merged
Conversation
…s instead of silent default
Author
|
@pradeeban pls take a look, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every failure path in read(), file missing, empty after retries, parse error, ZMQ timeout.... returned the same default list with no way for the caller to know why. In a control loop that's a silent bug: stale data looks like real data.
Added ReadStatus enum and ReadResult wrapper. Both file and ZMQ read() paths updated. Tests for each failure case included
closes #491