fix: dark mode actually works now#366
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Mar 9, 2026
Merged
Conversation
Author
|
@pradeeban fixed persistence + prefers-color-scheme fallback also and the toggle button's inline styles that were blocking dark overrides. Left the rest of the hardcoded colors alone since it's low priority anyway :p 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toggle was setting data-theme on the html element but nothing was reading it, inline hardcoded colors everywhere. also reset on every refresh with no persistence.
moved inline styles on the toggle button to a CSS class so dark overrides can target it
initialState reads from localStorage, falls back to prefers-color-scheme
localStorage.setItem wired into the existing theme useEffect in App.jsx
dark overrides for .textField in codeEdit (was pure #f5f5f5 regardless of theme)
closes #361