Fix TypeExtensions.ToTypeString method Exception.#639
Merged
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom Mar 12, 2023
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Fix TypeExtensions ToTypeString method throws if invoked on a generic class without specify the generic type
354e56f to
551921d
Compare
Sergio0694
approved these changes
Mar 12, 2023
Member
Sergio0694
left a comment
There was a problem hiding this comment.
Made a couple tweaks, but otherwise LGTM! ![]()
Thank you! 🙂
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TypeExtensions.ToTypeString method throws if invoked on a generic class without specifying the generic type.
Closes #609
Added a check on type.IsGenericParameter inside FormatDisplayString to avoid calling the method recursively given that, in this case, type.DeclaringType returns the parent class that defined the generic type parameter and this parent class was already taken into account by FormatDisplayString.
I've also added 2 tests for testing this case.
PR Checklist