Fix the slash inclusion and apply same duplicate project fix#120
Merged
michael-hawker merged 2 commits intomainfrom Aug 8, 2023
Merged
Fix the slash inclusion and apply same duplicate project fix#120michael-hawker merged 2 commits intomainfrom
michael-hawker merged 2 commits intomainfrom
Conversation
Update couple of usages where there'd be a duplicate slash
Arlodotexe
approved these changes
Aug 8, 2023
Member
Author
|
Labs and Windows builds passed, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From fixes in CommunityToolkit/Windows#165
Basically, we were hitting issues locally with the project references for UWP based projects having double slashes in the paths.
However, fixing that brought up an old issue CommunityToolkit/Windows#20 (comment) which broke the CI which we didn't understand at the time.
It appears like it is again the fact we're double-referencing the packages between projects that are required to build the toolkit, since we use the toolkit itself to do so...
This normalizes the
$RepositoryDirectoryto include the\but then not add it when used.Note that the
$ToolingDirectoryproperty is the opposite and does not include the\.