Fixed and updated UseTargetFrameworks script to accommodate submodule#109
Merged
michael-hawker merged 1 commit intomainfrom Jul 19, 2023
Merged
Conversation
Member
Author
|
Needed for CommunityToolkit/Windows#152 |
michael-hawker
approved these changes
Jul 19, 2023
Member
michael-hawker
left a comment
There was a problem hiding this comment.
Not sure if this is the root cause of the issues we're facing, but can't hurt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these issues during some testing.
The UseTargetFrameworks script wasn't adjusted for the submodule yet. and had some errors being silently thrown. We no longer need to use git to suppress changes as the user can't easily commit the altered files by mistake (being in a submodule).
This also improves the log output with some helpful advice. Nothing too fancy.