-
Notifications
You must be signed in to change notification settings - Fork 188
changelog: add missing versions (v0.9.0-v0.14.0, v0.25.0, backport patches) #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e179350
changelog: add missing versions (v0.9.0-v0.14.0, v0.25.0, backport pa…
lin-bot23 59b232f
changelog: improve backport entries with proper categories (Partner +…
lin-bot23 fb724d4
fix: reorder v0.19.x and v0.20.x to descending version order, standar…
lin-bot23 84dc389
Merge branch 'main' into pr/1158
comfyui-wiki fce47fd
Update changelog
comfyui-wiki c6216e7
Enhance translation handling and changelog structure
comfyui-wiki bf3bce3
Fix changelog semver order, date localization, and CodeRabbit review …
comfyui-wiki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Comfy-Org/docs
Length of output: 141
🏁 Script executed:
Repository: Comfy-Org/docs
Length of output: 100
🏁 Script executed:
head -n 120 .github/scripts/i18n/chunked-translate.ts | tail -n +90Repository: Comfy-Org/docs
Length of output: 1175
🏁 Script executed:
grep -n "parseBlockHashEntry" .github/scripts/i18n/chunked-translate.tsRepository: Comfy-Org/docs
Length of output: 193
🏁 Script executed:
sed -n '96,130p' .github/scripts/i18n/chunked-translate.tsRepository: Comfy-Org/docs
Length of output: 1105
🏁 Script executed:
sed -n '110,160p' .github/scripts/i18n/chunked-translate.tsRepository: Comfy-Org/docs
Length of output: 1387
🏁 Script executed:
Repository: Comfy-Org/docs
Length of output: 144
🏁 Script executed:
sed -n '115,150p' .github/scripts/i18n/chunked-translate.tsRepository: Comfy-Org/docs
Length of output: 977
Guard
JSON.parseagainst malformed escaped labels—prevent translation kaboom.At line 101,
JSON.parsecan throw when the regex matches a quoted key with invalid escape sequences (e.g.,\q). The malformed label slips past the regex but crashes on parse, derailing the entire translation run. Wrap the return in try-catch to gracefully returnnullinstead, staying true to the function's null-handling contract already in place.Suggested fix
if (quoted) { - return { label: JSON.parse(quoted[1]!) as string, hash: quoted[2]! }; + try { + return { label: JSON.parse(quoted[1]!) as string, hash: quoted[2]! }; + } catch { + return null; + } }📝 Committable suggestion
🤖 Prompt for AI Agents