Skip to content

chore(generate): rename X-Comfy-Env header to Comfy-Env#456

Merged
robinjhuang merged 1 commit into
mainfrom
feat/rename-comfy-env-header
May 18, 2026
Merged

chore(generate): rename X-Comfy-Env header to Comfy-Env#456
robinjhuang merged 1 commit into
mainfrom
feat/rename-comfy-env-header

Conversation

@robinjhuang

Copy link
Copy Markdown
Member

Renames the partner-node request header from X-Comfy-Env to Comfy-Env. Updates both call sites (client._auth_headers, app._refresh) and the three tests that assert on it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 18, 2026
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 27717178-8ff9-42bf-9342-82332e704287

📥 Commits

Reviewing files that changed from the base of the PR and between bfa7968 and 0d1f2d3.

📒 Files selected for processing (5)
  • comfy_cli/command/generate/app.py
  • comfy_cli/command/generate/client.py
  • tests/comfy_cli/command/generate/test_app.py
  • tests/comfy_cli/command/generate/test_client.py
  • tests/comfy_cli/command/generate/test_upload.py

📝 Walkthrough

Walkthrough

The CLI's API client standardizes HTTP environment header naming from X-Comfy-Env to Comfy-Env across the OpenAPI refresh request, client auth headers, and all corresponding test assertions. Header values and request behavior remain unchanged.

Changes

Header key standardization

Layer / File(s) Summary
Core header key update in API client and refresh
comfy_cli/command/generate/app.py, comfy_cli/command/generate/client.py
The _refresh method and _auth_headers function update the environment header key from X-Comfy-Env to Comfy-Env, dropping the vendor prefix while preserving header values and all other request logic.
Test assertions updated for header key
tests/comfy_cli/command/generate/test_app.py, tests/comfy_cli/command/generate/test_client.py, tests/comfy_cli/command/generate/test_upload.py
Cache refresh, client request, and signed-url test assertions are updated to expect Comfy-Env instead of X-Comfy-Env—looks like someone's header-ing in the right direction!
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/rename-comfy-env-header
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/rename-comfy-env-header

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files          44       44           
  Lines        6233     6233           
=======================================
  Hits         5120     5120           
  Misses       1113     1113           
Files with missing lines Coverage Δ
comfy_cli/command/generate/app.py 90.37% <100.00%> (ø)
comfy_cli/command/generate/client.py 77.01% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robinjhuang robinjhuang merged commit ad9a18e into main May 18, 2026
15 checks passed
@robinjhuang robinjhuang deleted the feat/rename-comfy-env-header branch May 18, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant