Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

feat: clean up requirements for conda#53

Merged
redeboer merged 6 commits into
ComPWA:masterfrom
redeboer:python
Feb 26, 2020
Merged

feat: clean up requirements for conda#53
redeboer merged 6 commits into
ComPWA:masterfrom
redeboer:python

Conversation

@redeboer

Copy link
Copy Markdown
Member
  • We now request the user to use at most Python 3.7 (see this issue on pybind).
  • The requirements.txt files have been split up into the essential, those for development and those for documentation
  • Versions have been remove if not necessary, because Conda takes care of that.

@redeboer redeboer requested a review from spflueger February 26, 2020 10:39
@codecov

codecov Bot commented Feb 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #53 into master will increase coverage by 5.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #53     +/-   ##
========================================
+ Coverage      80%   85.6%   +5.6%     
========================================
  Files          19      19             
  Lines        2660    2660             
========================================
+ Hits         2128    2277    +149     
+ Misses        532     383    -149
Impacted Files Coverage Δ
pycompwa/expertsystem/state/conservationrules.py 92.89% <0%> (+8.05%) ⬆️
pycompwa/expertsystem/state/propagation.py 93.22% <0%> (+10.15%) ⬆️
pycompwa/expertsystem/state/particle.py 89.9% <0%> (+17.43%) ⬆️

Comment thread doc/source/contribute.rst

The documentation is built with sphinx using the "read the docs" theme. For the
python code/modules ``sphinx-apidoc`` is used. The comment style is following
the ``pep8`` conventions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 are the conventions and doc8 is a tool

spflueger
spflueger previously approved these changes Feb 26, 2020
@spflueger

Copy link
Copy Markdown
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@spflueger spflueger self-requested a review February 26, 2020 12:46
@redeboer redeboer merged commit 458ece4 into ComPWA:master Feb 26, 2020
@redeboer redeboer deleted the python branch February 26, 2020 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants