Merged
Conversation
- Fix CreateArgs test helper: add all missing fields (example, source, sink, partition, etc.) and wrap problem in Some() - Merge duplicate #[cfg(test)] mod tests blocks into one - Remove duplicate Vec<u64> match arm in type_format_hint - Fix cli.rs test: use args.problem.as_deref() for Option<String> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 97.04% 97.06% +0.01%
==========================================
Files 284 286 +2
Lines 38037 38288 +251
==========================================
+ Hits 36914 37163 +249
- Misses 1123 1125 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zazabap
reviewed
Mar 17, 2026
Collaborator
zazabap
left a comment
There was a problem hiding this comment.
CI fix looks ok. compiled locally and passed checks.
zazabap
approved these changes
Mar 17, 2026
Collaborator
zazabap
left a comment
There was a problem hiding this comment.
Straightforward compile fix — all new CreateArgs fields added, type change handled, duplicate test module merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateArgstest helper: add all missing fields and wrapprobleminSome()#[cfg(test)] mod testsblocks into oneVec<u64>match arm intype_format_hintcli.rstest: useargs.problem.as_deref()forOption<String>These compile errors were introduced by the conflict resolution in #640 and only surface in the code coverage CI build.
🤖 Generated with Claude Code