Refactor generated doc exports and remove centralized trait tests#676
Merged
Refactor generated doc exports and remove centralized trait tests#676
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 97.02% 97.01% -0.02%
==========================================
Files 281 280 -1
Lines 37804 37611 -193
==========================================
- Hits 36681 36488 -193
Misses 1123 1123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace rigid per-model test function name checklist with flexible coverage guidance enforced by a minimum of 3 test functions. All three files (CLAUDE.md, add-model skill, structural reviewer) are now consistent on the threshold. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # docs/src/reductions/problem_schemas.json # docs/src/reductions/reduction_graph.json # src/unit_tests/trait_consistency.rs
These files were intentionally removed earlier in this branch; re-delete after merge conflict resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zazabap
added a commit
that referenced
this pull request
Mar 16, 2026
* Add plan for #251: [Model] BoundedComponentSpanningForest * Implement #251: [Model] BoundedComponentSpanningForest * chore: remove plan file after implementation * fix: address review feedback for bcsf * fix: preserve create variant errors for graph-backed problems * fix: address final review weaknesses - Add CeTZ figure to paper entry showing the 3-component partition with colored vertices, weight labels, and region backgrounds - Relax max_components assertion: K > |V| is mathematically harmless (just means fewer than K components will be used) - Update CLI validation and tests accordingly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove re-introduced trait_consistency.rs Main branch intentionally removed centralized trait tests in PR #676 (commit 9eaa786). The PR branch diverged before that removal, so our merge kept the PR's version. Aligning with main's intent by removing it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: simplify paper figure to avoid hobby/on-layer Use only g-node, g-edge, and content — the same primitives used by other figures in the paper. Removes hobby curve regions that could fail on older CeTZ versions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve CI failures — tempdir and dead code - Replace tempdir() with std::env::temp_dir() in CLI test (tempfile crate not available in test scope) - Remove unused cli_flag_name function (superseded by help_flag_name) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: merge cli_flag_name mappings into help_flag_name The cli_flag_name function was superseded by help_flag_name but its general field-name mappings (universe_size->universe, collection->sets, etc.) were still needed. Merge them into help_flag_name and remove the redundant function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: zazabap <sweynan@icloud.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/src/reductions/reduction_graph.jsonandproblem_schemas.jsonas generated doc artifacts instead of committed filessrc/unit_tests/trait_consistency.rsmodule and the automation/docs that required itTest Plan