Fix #500: [Model] SequencingToMinimizeMaximumCumulativeCost#674
Open
Fix #500: [Model] SequencingToMinimizeMaximumCumulativeCost#674
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 97.04% 97.04% -0.01%
==========================================
Files 284 286 +2
Lines 38037 38289 +252
==========================================
+ Hits 36914 37158 +244
- Misses 1123 1131 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Implementation SummaryChanges
Deviations from Plan
Open Questions
|
There was a problem hiding this comment.
Pull request overview
Adds the SequencingToMinimizeMaximumCumulativeCost model (G&J SS7) to the core library, including schema/variant registration, example-db fixture, CLI pred create wiring, unit + CLI tests, and documentation/paper updates.
Changes:
- Implement the new satisfaction model using Lehmer-code configurations and precedence/prefix-sum validation.
- Wire the model into the library exports, example DB fixtures, and CLI creation (including shared precedence-pair parsing/validation).
- Regenerate/update docs JSON and extend the paper with the new model description + references.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/misc/sequencing_to_minimize_maximum_cumulative_cost.rs | New model implementation + schema registration + variants + example-db hook |
| src/models/misc/mod.rs | Registers the new misc model module and example-db specs |
| src/models/mod.rs | Re-exports the new model from models |
| src/lib.rs | Re-exports the new model from the public prelude |
| src/unit_tests/models/misc/sequencing_to_minimize_maximum_cumulative_cost.rs | New unit tests covering construction, evaluation, brute-force, serialization, edge cases |
| src/unit_tests/trait_consistency.rs | Adds trait-consistency coverage for the new model |
| src/example_db/fixtures/examples.json | Adds canonical example fixture + satisfying configs |
| problemreductions-cli/src/cli.rs | Adds --costs flag and help-line for the new problem type |
| problemreductions-cli/src/commands/create.rs | Adds creation path for the new model and shared --precedence-pairs parsing/validation helpers |
| problemreductions-cli/tests/cli_tests.rs | Adds CLI tests for pred create SequencingToMinimizeMaximumCumulativeCost (success + error cases) |
| docs/src/reductions/problem_schemas.json | Adds generated schema entry for the new model |
| docs/src/reductions/reduction_graph.json | Adds generated node entry for the new model (index shifts reflected in edges) |
| docs/paper/references.bib | Adds references for series-parallel precedence results |
| docs/paper/reductions.typ | Adds paper definition/description/example/figure section for the new model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…00-sequencing-to-minimize-maximum-cumulative-cost # Conflicts: # docs/paper/reductions.typ # docs/src/reductions/problem_schemas.json # docs/src/reductions/reduction_graph.json # problemreductions-cli/src/commands/create.rs # src/example_db/fixtures/examples.json # src/lib.rs # src/models/misc/mod.rs # src/models/mod.rs # src/unit_tests/trait_consistency.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the implementation plan for SequencingToMinimizeMaximumCumulativeCost, including the model design, CLI wiring, tests, and paper work.
Fixes #500