Fix #498: [Model] SequencingToMinimizeWeightedTardiness#672
Open
Fix #498: [Model] SequencingToMinimizeWeightedTardiness#672
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 273 273
Lines 36505 36505
=======================================
Hits 35388 35388
Misses 1117 1117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new NP-complete scheduling model, SequencingToMinimizeWeightedTardiness (1 || Σ w_j T_j), and integrates it across the crate (exports, schema/variants, examples, CLI creation support, tests, and documentation/paper).
Changes:
- Introduces
SequencingToMinimizeWeightedTardinessmodel with Lehmer-code encoding, schema registration, and declared default variant complexity. - Adds unit tests + example-db fixture entry for the new model.
- Extends
pred createCLI support (flags, examples, tests) and regenerates docs JSON + paper section/bibliography.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/models/misc/sequencing_to_minimize_weighted_tardiness.rs |
New problem model implementation + schema entry + variants + example-db spec + test wiring |
src/models/misc/mod.rs |
Registers and re-exports the new misc model; adds to example-db aggregation |
src/models/mod.rs |
Re-exports the new model at the top-level models module |
src/lib.rs |
Re-exports the new model in the public prelude |
src/unit_tests/models/misc/sequencing_to_minimize_weighted_tardiness.rs |
New model-focused unit tests (evaluation, invalid configs, solver, serialization) |
src/unit_tests/trait_consistency.rs |
Adds the new model to trait consistency checks |
src/example_db/fixtures/examples.json |
Adds a canonical example instance + sample/optimal configs |
problemreductions-cli/src/commands/create.rs |
Adds pred create SequencingToMinimizeWeightedTardiness parsing + example usage text |
problemreductions-cli/src/cli.rs |
Documents required flags for the new pred create problem type |
problemreductions-cli/tests/cli_tests.rs |
Adds CLI tests for successful creation, mismatch rejection, and help output |
docs/src/reductions/problem_schemas.json |
Adds generated schema entry for the new model |
docs/src/reductions/reduction_graph.json |
Adds generated graph node for the new model and reindexes affected edges |
docs/paper/references.bib |
Adds bibliography entries referenced by the new paper section |
docs/paper/reductions.typ |
Adds the paper definition + example/figure block for the new model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+920
to
+926
| // SequencingToMinimizeWeightedTardiness | ||
| "SequencingToMinimizeWeightedTardiness" => { | ||
| let sizes_str = args.sizes.as_deref().ok_or_else(|| { | ||
| anyhow::anyhow!( | ||
| "SequencingToMinimizeWeightedTardiness requires --sizes, --weights, --deadlines, and --bound\n\n\ | ||
| Usage: pred create SequencingToMinimizeWeightedTardiness --sizes 3,4,2,5,3 --weights 2,3,1,4,2 --deadlines 5,8,4,15,10 --bound 13" | ||
| ) |
| } | ||
|
|
||
| @article{tanaka2009, | ||
| author = {Shunji Tanaka and Shuji Fujikuma and Mituhiko Araki}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the execution plan and implementation for SequencingToMinimizeWeightedTardiness.
Fixes #498