Fix #233: [Model] StrongConnectivityAugmentation by GiggleLiu · Pull Request #652 · CodingThrust/problem-reductions

GiggleLiu · 2026-03-15T21:00:35Z

Summary

Add the StrongConnectivityAugmentation satisfaction model for issue [Model] StrongConnectivityAugmentation #233
Integrate the model across the registry, example DB, CLI creation flow, exports, tests, and paper/docs
Include follow-up review cleanups on the strong-connectivity helper and test/runtime polish

Fixes #233

codecov · 2026-03-15T21:02:40Z

Codecov Report

❌ Patch coverage is 97.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.07%. Comparing base (6802d3f) to head (7716c81).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/models/graph/strong_connectivity_augmentation.rs	94.52%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main     #652    +/-   ##
========================================
  Coverage   97.07%   97.07%            
========================================
  Files         288      290     +2     
  Lines       38490    38778   +288     
========================================
+ Hits        37365    37645   +280     
- Misses       1125     1133     +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds the new StrongConnectivityAugmentation directed-graph satisfaction model (issue #233) and wires it into the registry, example DB, CLI (pred create), reduction-graph docs exports, and the paper.

Changes:

Implement StrongConnectivityAugmentation model (schema/variants, evaluation, example-db canonical instance) plus unit tests.
Add DirectedGraph::is_strongly_connected() and associated topology tests.
Integrate the model across exports/fixtures/docs and add CLI creation + validation tests.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`src/models/graph/strong_connectivity_augmentation.rs`	New model implementation + schema/variants + canonical example-db spec
`src/models/graph/mod.rs`	Register module/export and include canonical example spec
`src/models/mod.rs`	Re-export `StrongConnectivityAugmentation` from `models`
`src/lib.rs`	Add model to the public prelude exports
`src/topology/directed_graph.rs`	Add `is_strongly_connected()` helper used by the model
`src/unit_tests/topology/directed_graph.rs`	Tests for `is_strongly_connected()`
`src/unit_tests/models/graph/strong_connectivity_augmentation.rs`	Model behavior/serialization/solver tests
`src/unit_tests/trait_consistency.rs`	Ensure the new model implements core traits correctly
`src/unit_tests/example_db.rs`	Assert canonical example is discoverable via example DB
`src/example_db/fixtures/examples.json`	Add canonical example fixture for StrongConnectivityAugmentation
`problemreductions-cli/src/cli.rs`	Add `--candidate-arcs` flag and help text wiring
`problemreductions-cli/src/commands/create.rs`	Implement `pred create StrongConnectivityAugmentation` parsing/validation
`problemreductions-cli/src/problem_name.rs`	Add create-specific resolver that prefers graph-backed variants
`problemreductions-cli/src/dispatch.rs`	Add test coverage for rejecting invalid SCA instances on load
`problemreductions-cli/tests/cli_tests.rs`	CLI tests for create + error cases
`docs/src/reductions/problem_schemas.json`	Generated schema export includes SCA
`docs/src/reductions/reduction_graph.json`	Generated reduction-graph export includes SCA node
`docs/paper/references.bib`	Add Eswaran–Tarjan reference
`docs/paper/reductions.typ`	Add paper entry + figure for SCA
`docs/plans/2026-03-16-strong-connectivity-augmentation.md`	Add implementation plan document

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/unit_tests/models/graph/strong_connectivity_augmentation.rs

+    assert!(problem.evaluate(&config));
+
+    let solver = BruteForce::new();
+    let all_satisfying = solver.find_all_satisfying(&problem);
+    assert_eq!(all_satisfying.len(), 1);
+    assert_eq!(all_satisfying[0], config);


src/topology/directed_graph.rs

+    /// Returns `true` if every vertex can reach every other vertex.
+    pub fn is_strongly_connected(&self) -> bool {
+        let n = self.num_vertices();
+        if n <= 1 {
+            return true;
+        }
+
+        fn visit(
+            graph: &DirectedGraph,
+            start: usize,
+            neighbors: impl Fn(&DirectedGraph, usize) -> Vec<usize>,
+        ) -> Vec<bool> {
+            let mut seen = vec![false; graph.num_vertices()];
+            let mut stack = vec![start];
+            seen[start] = true;
+
+            while let Some(v) = stack.pop() {
+                for u in neighbors(graph, v) {
+                    if !seen[u] {
+                        seen[u] = true;
+                        stack.push(u);
+                    }
+                }
+            }
+
+            seen
+        }
+
+        let forward = visit(self, 0, DirectedGraph::successors);
+        if forward.iter().any(|&seen| !seen) {
+            return false;
+        }
+
+        let reverse = visit(self, 0, DirectedGraph::predecessors);
+        reverse.iter().all(|&seen| seen)
+    }


docs/plans/2026-03-16-strong-connectivity-augmentation.md

+# StrongConnectivityAugmentation Implementation Plan
+
+> **For Claude:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task.
+
+**Goal:** Add the `StrongConnectivityAugmentation` model from issue #233 as a directed-graph satisfaction problem, with registry/example-db/CLI integration, paper documentation, and verification.
+
+**Architecture:** Reuse the repo's existing `DirectedGraph` wrapper for the base digraph, store augmentable weighted arcs explicitly, and treat each binary variable as "add this candidate arc". Evaluation should accept exactly those configurations whose selected candidate arcs stay within the bound and make the augmented digraph strongly connected. Keep the paper/example writing in a separate batch after the model, tests, exports, and fixtures are complete.
+
+**Tech Stack:** Rust workspace, `inventory` schema registry, `declare_variants!`, `DirectedGraph`, `BruteForce`, `pred create`, example-db fixtures, Typst paper, `make` verification targets.


docs/plans/2026-03-16-strong-connectivity-augmentation.md

+# StrongConnectivityAugmentation Implementation Plan
+
+> **For Claude:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task.
+
+**Goal:** Add the `StrongConnectivityAugmentation` model from issue #233 as a directed-graph satisfaction problem, with registry/example-db/CLI integration, paper documentation, and verification.


…33-strong-connectivity-augmentation

GiggleLiu · 2026-03-16T04:24:56Z

Review Pipeline Report

Check	Result
Copilot comments	4 fixed
Issue/human comments	2 checked, 0 changes needed
Structural review	manual pass (completeness pass; whitelist check was a stale tooling false positive)
CI	green
Agentic test	passed after doc fixes
Needs human decision	none
Board	Review pool -> Under review -> Final review

Remaining issues for final review

None.

Generated by review-pipeline

Resolve merge conflicts by taking main's versions for all existing models and infrastructure, then adding StrongConnectivityAugmentation on top. All 11 conflicts resolved: - src/lib.rs, models/graph/mod.rs, models/mod.rs: added SCA exports - trait_consistency.rs: added SCA check_problem_trait entry - examples.json: regenerated fixtures (42 models, 42 rules) - CLI files: added --candidate-arcs flag and SCA create support - docs/paper/reductions.typ: added SCA display-name and problem-def - docs/src/reductions/*.json: accepted deletion (refactored on main) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Add candidate_arcs: None to empty_args() test helper in create.rs - Mark resolve_create_problem_ref as #[cfg(test)] since it's only used in test code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This function exists on the PR branch but is currently only used in tests. Suppress with #[allow(dead_code)] rather than changing its visibility — not part of this PR's scope. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Remove duplicate eswarantarjan1976 BibTeX entry - Revert unrelated README/docs workspace-local build instructions - Remove unused resolve_create_problem_ref and its tests - Revert unrelated KSat→Sat examples.json solution change - Remove redundant test_strong_connectivity_augmentation_paper_example Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The import is needed by resolve_problem_ref which exists on main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

DirectedGraph serializes as {inner: {nodes, edges}}, not {num_vertices, arcs}. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add plan for #233: [Model] StrongConnectivityAugmentation

d53eb7e

GiggleLiu added 6 commits March 16, 2026 05:04

feat: add directed strong connectivity check

3abec4f

feat: add strong connectivity augmentation model

cf0206c

feat: register strong connectivity augmentation

4ffeded

feat: add CLI support for strong connectivity augmentation

acdf1d0

docs: add strong connectivity augmentation to paper

bd73eb1

fix: address strong connectivity augmentation review findings

b2068ca

GiggleLiu requested a review from Copilot March 15, 2026 21:45

Copilot started reviewing on behalf of GiggleLiu March 15, 2026 21:45 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

GiggleLiu added 3 commits March 16, 2026 11:15

Merge remote-tracking branch 'origin/main' into review-pr-652-issue-2…

337d1ae

…33-strong-connectivity-augmentation

fix: address PR #652 review comments

8e77d0e

docs: improve StrongConnectivityAugmentation CLI guidance

93a6dd4

isPANN self-assigned this Mar 17, 2026

isPANN and others added 5 commits March 17, 2026 17:28

fix: add missing candidate_arcs field and suppress unused warning

ee0098e

- Add candidate_arcs: None to empty_args() test helper in create.rs - Mark resolve_create_problem_ref as #[cfg(test)] since it's only used in test code Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: restore ProblemRef import removed by cleanup

930ef81

The import is needed by resolve_problem_ref which exists on main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: use correct DirectedGraph JSON paths in paper Typst template

7716c81

DirectedGraph serializes as {inner: {nodes, edges}}, not {num_vertices, arcs}. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

isPANN approved these changes Mar 17, 2026

View reviewed changes

isPANN merged commit e12f11c into main Mar 17, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #233: [Model] StrongConnectivityAugmentation#652

Fix #233: [Model] StrongConnectivityAugmentation#652
isPANN merged 16 commits intomainfrom
issue-233-strong-connectivity-augmentation

GiggleLiu commented Mar 15, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

GiggleLiu commented Mar 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

GiggleLiu commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

codecov bot commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

GiggleLiu commented Mar 16, 2026

Review Pipeline Report

Remaining issues for final review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GiggleLiu commented Mar 15, 2026 •

edited

Loading

codecov bot commented Mar 15, 2026 •

edited

Loading